This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
handle proxy redirects even if the scheme doesn't match #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, when receiving a Location header, nginx will rewrite it to reference a URL if it matches the proxy_pass. This breaks when the scheme changes, since proxy_pass can have a scheme. For instance, if you have a proxy: "https://www.foo.com", but the Location on a redirect from that site returns "http://www.foo.com" nginx won't rewrite the URL. This fixes it by specifying the redirect for both http and https.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, when receiving a
Locationheader, nginx will rewrite it to reference a URL if it matches theproxy_pass. This breaks when the scheme changes, sinceproxy_passcan have a scheme. For instance, if you have a proxy: "https://www.foo.com", but theLocationon a redirect from that site returns "http://www.foo.com" nginx won't rewrite the URL. This fixes it by specifying the redirect for both http and https.