fix: ensure error is defined

Author: jdx

package.json

@@ -7,7 +7,7 @@
   "dependencies": {
     "@heroku-cli/color": "^1.1.5",
     "@oclif/errors": "^1.1.2",
-    "cli-ux": "^4.6.0",
+    "cli-ux": "^4.6.1",
     "debug": "^3.1.0",
     "fs-extra": "^6.0.1",
     "heroku-client": "^3.0.6",
@@ -16,29 +16,29 @@
     "opn": "^5.3.0"
   },
   "devDependencies": {
-    "@heroku-cli/schema": "^1.0.4",
+    "@heroku-cli/schema": "^1.0.5",
     "@heroku-cli/tslint": "^1.1.4",
-    "@oclif/command": "^1.4.32",
+    "@oclif/command": "^1.4.33",
     "@oclif/config": "^1.6.27",
     "@oclif/tslint": "^1.1.2",
     "@types/ansi-styles": "^3.2.0",
     "@types/chai": "^4.1.3",
-    "@types/fs-extra": "^5.0.2",
-    "@types/mocha": "^5.2.0",
+    "@types/fs-extra": "^5.0.3",
+    "@types/mocha": "^5.2.1",
     "@types/nock": "^9.1.3",
-    "@types/node": "^10.3.0",
+    "@types/node": "^10.3.2",
     "@types/opn": "^5.1.0",
     "@types/proxyquire": "^1.3.28",
     "@types/sinon": "^5.0.1",
     "@types/supports-color": "^5.3.0",
     "chai": "^4.1.2",
     "fancy-test": "^1.1.4",
     "mocha": "^5.2.0",
-    "nock": "^9.3.0",
+    "nock": "^9.3.2",
     "proxyquire": "^2.0.1",
-    "sinon": "^5.0.10",
+    "sinon": "^5.1.1",
     "testdouble": "^3.8.1",
-    "ts-node": "^6.0.5",
+    "ts-node": "^6.1.0",
     "tslint": "^5.10.0",
     "typescript": "^2.9.1"
   },

src/api_client.ts

@@ -33,6 +33,7 @@ export class HerokuAPIError extends CLIError {
   body: IHerokuAPIErrorOptions
 
   constructor(httpError: HTTPError) {
+    if (!httpError) throw new Error('invalid error')
     let options: IHerokuAPIErrorOptions = httpError.body
     if (!options || !options.message) throw httpError
     let info = []

yarn.lock

@@ -27,9 +27,9 @@
     strip-ansi "^4.0.0"
     supports-color "^5.4.0"
 
-"@heroku-cli/schema@^1.0.4":
-  version "1.0.4"
-  resolved "https://registry.yarnpkg.com/@heroku-cli/schema/-/schema-1.0.4.tgz#1753b101132544e28bef689a9faa56839a59d631"
+"@heroku-cli/schema@^1.0.5":
+  version "1.0.5"
+  resolved "https://registry.yarnpkg.com/@heroku-cli/schema/-/schema-1.0.5.tgz#5c476187b75c581d8544f3afb05abfe8b686cbc2"
 
 "@heroku-cli/tslint@^1.1.4":
   version "1.1.4"
@@ -38,12 +38,12 @@
     tslint "^5.8.0"
     tslint-config-prettier "*"
 
-"@oclif/command@^1.4.32":
-  version "1.4.32"
-  resolved "https://registry.yarnpkg.com/@oclif/command/-/command-1.4.32.tgz#1cb2eb9637340a1ac69da35e407316688f736647"
+"@oclif/command@^1.4.33":
+  version "1.4.33"
+  resolved "https://registry.yarnpkg.com/@oclif/command/-/command-1.4.33.tgz#40a48e7384d6b4394c2ca20e5c05ff45541087f5"
   dependencies:
     "@oclif/errors" "^1.1.2"
-    "@oclif/parser" "^3.4.1"
+    "@oclif/parser" "^3.5.1"
     debug "^3.1.0"
     semver "^5.5.0"
 
@@ -68,9 +68,9 @@
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/@oclif/linewrap/-/linewrap-1.0.0.tgz#aedcb64b479d4db7be24196384897b5000901d91"
 
-"@oclif/parser@^3.4.1":
-  version "3.4.1"
-  resolved "https://registry.yarnpkg.com/@oclif/parser/-/parser-3.4.1.tgz#83942276f3cf9406a1a3dcf3eb917183d6333e1d"
+"@oclif/parser@^3.5.1":
+  version "3.5.1"
+  resolved "https://registry.yarnpkg.com/@oclif/parser/-/parser-3.5.1.tgz#2f60ac9773565786b6e1afff967b36a6399defcc"
   dependencies:
     "@oclif/linewrap" "^1.0.0"
     chalk "^2.4.1"
@@ -105,9 +105,9 @@
   version "1.1.0"
   resolved "https://registry.yarnpkg.com/@types/color-name/-/color-name-1.1.0.tgz#926f76f7e66f49cc59ad880bb15b030abbf0b66d"
 
-"@types/fs-extra@^5.0.2":
-  version "5.0.2"
-  resolved "https://registry.yarnpkg.com/@types/fs-extra/-/fs-extra-5.0.2.tgz#235a7e2b56452cc0a6a4809b53e1d1eaffff9c96"
+"@types/fs-extra@^5.0.3":
+  version "5.0.3"
+  resolved "https://registry.yarnpkg.com/@types/fs-extra/-/fs-extra-5.0.3.tgz#feb31d55eeae3ccd5f92dbce806344a6c777a713"
   dependencies:
     "@types/node" "*"
 
@@ -119,6 +119,10 @@
   version "5.2.0"
   resolved "https://registry.yarnpkg.com/@types/mocha/-/mocha-5.2.0.tgz#b3c8e69f038835db1a7fdc0b3d879fc50506e29e"
 
+"@types/mocha@^5.2.1":
+  version "5.2.1"
+  resolved "https://registry.yarnpkg.com/@types/mocha/-/mocha-5.2.1.tgz#465450aaf5cec6f7d35523748c6cc89a5e222dc5"
+
 "@types/nock@^9.1.3":
   version "9.1.3"
   resolved "https://registry.yarnpkg.com/@types/nock/-/nock-9.1.3.tgz#1d445679375b9e25afd449dc56585f81729454e8"
@@ -133,6 +137,10 @@
   version "10.3.0"
   resolved "https://registry.yarnpkg.com/@types/node/-/node-10.3.0.tgz#078516315a84d56216b5d4fed8f75d59d3b16cac"
 
+"@types/node@^10.3.2":
+  version "10.3.2"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-10.3.2.tgz#3840ec6c12556fdda6e0e6d036df853101d732a4"
+
 "@types/opn@^5.1.0":
   version "5.1.0"
   resolved "https://registry.yarnpkg.com/@types/opn/-/opn-5.1.0.tgz#bff7bc371677f4bdbb37884400e03fd81f743927"
@@ -266,9 +274,9 @@ clean-stack@^1.3.0:
   version "1.3.0"
   resolved "https://registry.yarnpkg.com/clean-stack/-/clean-stack-1.3.0.tgz#9e821501ae979986c46b1d66d2d432db2fd4ae31"
 
-cli-ux@^4.6.0:
-  version "4.6.0"
-  resolved "https://registry.yarnpkg.com/cli-ux/-/cli-ux-4.6.0.tgz#b3c6c4525c66ae0b6c0003db119609cd65c0a9ab"
+cli-ux@^4.6.1:
+  version "4.6.1"
+  resolved "https://registry.yarnpkg.com/cli-ux/-/cli-ux-4.6.1.tgz#2cc7feb4d48932a95bffe712426eaa36ec861004"
   dependencies:
     "@oclif/linewrap" "^1.0.0"
     "@oclif/screen" "^1.0.2"
@@ -711,9 +719,9 @@ nise@^1.3.3:
     path-to-regexp "^1.7.0"
     text-encoding "^0.6.4"
 
-nock@^9.3.0:
-  version "9.3.0"
-  resolved "https://registry.yarnpkg.com/nock/-/nock-9.3.0.tgz#4dcfdd37bd249836754d05bbac5a1f05e12e0f16"
+nock@^9.3.2:
+  version "9.3.2"
+  resolved "https://registry.yarnpkg.com/nock/-/nock-9.3.2.tgz#f2f52a784a8a33d7496f4ab5b28c3b879091e6d6"
   dependencies:
     chai "^4.1.2"
     debug "^3.1.0"
@@ -847,9 +855,9 @@ signal-exit@^3.0.0:
   version "3.0.2"
   resolved "https://registry.yarnpkg.com/signal-exit/-/signal-exit-3.0.2.tgz#b5fdc08f1287ea1178628e415e25132b73646c6d"
 
-sinon@^5.0.10:
-  version "5.0.10"
-  resolved "https://registry.yarnpkg.com/sinon/-/sinon-5.0.10.tgz#a282b36a7475664c9f98719108e5546907129023"
+sinon@^5.1.1:
+  version "5.1.1"
+  resolved "https://registry.yarnpkg.com/sinon/-/sinon-5.1.1.tgz#19c59810ffb733ea6e76a28b94a71fc4c2f523b8"
   dependencies:
     "@sinonjs/formatio" "^2.0.0"
     diff "^3.5.0"
@@ -859,9 +867,9 @@ sinon@^5.0.10:
     supports-color "^5.4.0"
     type-detect "^4.0.8"
 
-source-map-support@^0.5.3:
-  version "0.5.5"
-  resolved "https://registry.yarnpkg.com/source-map-support/-/source-map-support-0.5.5.tgz#0d4af9e00493e855402e8ec36ebed2d266fceb90"
+source-map-support@^0.5.6:
+  version "0.5.6"
+  resolved "https://registry.yarnpkg.com/source-map-support/-/source-map-support-0.5.6.tgz#4435cee46b1aab62b8e8610ce60f788091c51c13"
   dependencies:
     buffer-from "^1.0.0"
     source-map "^0.6.0"
@@ -946,17 +954,16 @@ theredoc@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/theredoc/-/theredoc-1.0.0.tgz#bcace376af6feb1873efbdd0f91ed026570ff062"
 
-ts-node@^6.0.5:
-  version "6.0.5"
-  resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-6.0.5.tgz#977c1c931da7a2b09ae2930101f0104a5c2271e9"
+ts-node@^6.1.0:
+  version "6.1.0"
+  resolved "https://registry.yarnpkg.com/ts-node/-/ts-node-6.1.0.tgz#a2c37a11fdb58e60eca887a1269b025cf4d2f8b8"
   dependencies:
     arrify "^1.0.0"
-    chalk "^2.3.0"
     diff "^3.1.0"
     make-error "^1.1.1"
     minimist "^1.2.0"
     mkdirp "^0.5.1"
-    source-map-support "^0.5.3"
+    source-map-support "^0.5.6"
     yn "^2.0.0"
 
 tslib@1.9.0, tslib@^1.7.1, tslib@^1.8.0, tslib@^1.8.1: