Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Fail psql if the tunnel fails #99

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Conversation

msakrejda
Copy link
Contributor

This is especially important since the tunnel promise can resolve even
if the authentication information is incorrect, which leads to an ugly
stack trace propagated to the client.

This is especially important since the tunnel promise can resolve even
if the authentication information is incorrect, which leads to an ugly
stack trace propagated to the client.
@msakrejda
Copy link
Contributor Author

/cc @neovintage

@codecov-io
Copy link

Codecov Report

Merging #99 into master will decrease coverage by 0.18%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   95.97%   95.79%   -0.19%     
==========================================
  Files          42       42              
  Lines         994      998       +4     
==========================================
+ Hits          954      956       +2     
- Misses         40       42       +2
Impacted Files Coverage Δ
lib/bastion.js 90.9% <60%> (-4.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf72fe...41b67db. Read the comment docs.

Copy link
Contributor

@camillebaldock camillebaldock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

@msakrejda msakrejda merged commit f72bf48 into master Apr 3, 2017
@msakrejda msakrejda deleted the fix-tunnel-error-handling branch April 3, 2017 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants