Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Basic support for config data during addon install #6

Merged
merged 1 commit into from
Mar 27, 2012
Merged

Conversation

asenchi
Copy link

@asenchi asenchi commented Mar 27, 2012

No description provided.

@geemus
Copy link
Contributor

geemus commented Mar 27, 2012

@asenchi - is there customer facing differences when you specify config? IE do addons/list and other things tell you about the config you chose? I haven't worked with it enough to know, and if it does we would want to update the associated mocks as well:
https://github.com/heroku/heroku.rb/blob/master/lib/heroku/api/mock/addons.rb
If that data is only passed here though and isn't resurfaced from the API elsewhere then this is done. Just wanted to discuss so that part doesn't get lost. Thanks!

@asenchi
Copy link
Author

asenchi commented Mar 27, 2012

@geemus Honestly, I am not sure. I don't believe it is, as I think core just transparently sends it to the add-on. I can do some digging to make sure.

geemus pushed a commit that referenced this pull request Mar 27, 2012
Basic support for config data during addon install
@geemus geemus merged commit 96cc89e into master Mar 27, 2012
@geemus
Copy link
Contributor

geemus commented Mar 27, 2012

@asenchi got it. I went ahead and merged this but we should update if we find those other differences. We should update api-docs as well, see: heroku/api-docs#7. Also, did you need me to cut a release with this so that you can use it?

@asenchi
Copy link
Author

asenchi commented Mar 27, 2012

@geemus If you don't mind cutting a release, that would be swell. Otherwise, I can just vendor master for now and pick it up later. Let me know what works for you.

@geemus
Copy link
Contributor

geemus commented Mar 27, 2012

@asenchi - I think some of the integration tests currently fail (because we
changed what add ons are installed by default). I'd like to take the time
to fix all of that before I cut a release, so I'll add it to my short term
list but it is somewhat lower priority at the moment than a couple other
items.

On Tue, Mar 27, 2012 at 3:07 PM, Curt Micol <
reply@reply.github.com

wrote:

@geemus If you don't mind cutting a release, that would be swell.
Otherwise, I can just vendor master for now and pick it up later. Let me
know what works for you.


Reply to this email directly or view it on GitHub:
#6 (comment)

@asenchi
Copy link
Author

asenchi commented Mar 27, 2012

@geemus np, let me know if you need anything from me. I'll take a look at the api-docs stuff sometime this week.

@geemus
Copy link
Contributor

geemus commented Mar 27, 2012

@asenchi sounds good. I think a release this week is quite doable, but I have a couple other things I'd like to make progress on first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants