Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Request to /oauth/authorizations can return an unexpected 206 status #150

Open
dmcinnes opened this issue Apr 22, 2015 · 1 comment
Open

Comments

@dmcinnes
Copy link
Contributor

https://github.com/heroku/identity/blob/master/lib/identity/helpers/auth.rb#L37-L38

If a user tries to connect to an untrusted client but has more than 1000 tokens (a recent problem because our cleaner was backed up) the call to GET /oauth/authorizations returns a 206 response, causing a 500 in Identity.
We shouldn't just add it to the expects array, because the token we seek might exist in the remaining auths, probably we should iterate over the range.

@brandur
Copy link
Contributor

brandur commented Apr 22, 2015

Doh! This one is really embarrassing. We can't even get our own pagination right ;) +1 and thanks for logging this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants