Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick tweaks #3

Merged
merged 5 commits into from
Oct 14, 2014
Merged

Quick tweaks #3

merged 5 commits into from
Oct 14, 2014

Conversation

pedro
Copy link

@pedro pedro commented Oct 8, 2014

  • add rake spec/default rake task
  • explicitly require secure random: I didn't need it when running tests with the rspec binary, but saw failures by running just rake. It seems like the binary requires it for you.
  • add guard + guard-rspec to the gemspec to avoid annoying warnings

@pedro pedro mentioned this pull request Oct 8, 2014
Merged
@will
Copy link
Contributor

will commented Oct 8, 2014

This broke travis https://travis-ci.org/heroku/minitel/jobs/37440204

I wonder though if it should be --without-development?

@pedro
Copy link
Author

pedro commented Oct 8, 2014

ooooooshit. can't install it on 1.9.2.
any chance we can assume everyone at heroku is super responsible and not using 1.9.2 any longer? 💃

@will
Copy link
Contributor

will commented Oct 14, 2014

the thing that was 192 is not an important thing apparently, so kill it

@will
Copy link
Contributor

will commented Oct 14, 2014

added a thing to remove 192 from travis and rebased this branch

@will will merged commit cafe489 into master Oct 14, 2014
@will will deleted the pedro-tweaks branch October 14, 2014 20:50
@pedro
Copy link
Author

pedro commented Oct 14, 2014

👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro @will