Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-kit/metrics: add open-telemetry provider #149

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

agnaite
Copy link
Member

@agnaite agnaite commented Sep 16, 2021

This adds an open-telemetry metrics provider that satisfies the go-kit metrics Provider interface.

The PR also includes minor changes in other packages to fix lint errors.

@agnaite agnaite self-assigned this Sep 16, 2021
@agnaite agnaite requested a review from ypaq September 16, 2021 21:49
Copy link
Contributor

@ypaq ypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@@ -0,0 +1,10 @@
/* Copyright (c) 2018 Salesforce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2021?

@agnaite agnaite merged commit 7b679f9 into master Sep 17, 2021
@agnaite agnaite deleted the add-otel-metrics-provider branch September 17, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants