Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit with code 1 when cmd.Run() returns error #9

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

liuxh0
Copy link
Contributor

@liuxh0 liuxh0 commented Dec 18, 2020

As discussed in #8, I think this is the way we want it, right?

image

@liuxh0
Copy link
Contributor Author

liuxh0 commented Dec 18, 2020

BTW I used go get ./... and godep restore to download dependencies. It seems the v2 of github.com/urfave/cli is downloaded. Therefore I got a lot of compile errors because of type mismatch. Manually changing to v1 branch fixes the problem.

Shouldn't the version of github.com/urfave/cli go into Godeps.json?

@herrjulz
Copy link
Owner

Hi @liuxh0 , sorry for my very late response and thank you for your PR. The PR looks good. I'll check the issue with the dependencies.

@herrjulz herrjulz merged commit 7ccf488 into herrjulz:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants