Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At ethereumjs/ethereumjs-monorepo#785 (comment), we found that
exports
shouldn't guide the browser/node detection. It is usually present in browser builds made with Browserify, invalidating that clause.While as ridiculous as it sounds, there isn't a certain way to know the platform for sure, but I propose at least this better heuristic, using
window
instead. The likelihood of a Node project to have awindow
global variable seems to be super low.Additional ways to detect platforms involve:
self
andglobal
.More on this: https://v8.dev/features/globalthis.