Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nyc from dependencies to devDependencies #17

Closed

Conversation

holgerd77
Copy link

Hi @herumi, thanks for this great library, we are using it for the EIP-2537 BLS precompile implementation for our JavaScript EVM! 😄

We currently have the problem though that the nyc package currently being in the dependencies of the library is pulling in a hell lot of security vulnerabilities - some marked as high - when running npm audit on the library.

Would it be possible to merge and do a patch release on this relatively quickly? We are planning to do a new major version on the VM in two weeks and will feature-freeze at the end of next week (sorry, stumbled upon this a bit late in the process), and I'm afraid that we would otherwise have to disable the EIP-2537 support for now for security reasons.

That would be great and super helpful! 🙂

@herumi
Copy link
Owner

herumi commented Nov 14, 2020

Thank you for the patch.
I've changed the file-layout and removed the dependency.
Could you check it?

@rumkin
Copy link

rumkin commented Nov 16, 2020

I've checked this exact issue and it's solved. I think this PR could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants