Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Limit parallel deletes #779

Closed
apricote opened this issue Jun 11, 2024 · 1 comment · Fixed by #784
Closed

feat: Limit parallel deletes #779

apricote opened this issue Jun 11, 2024 · 1 comment · Fixed by #784
Assignees
Labels

Comments

@apricote
Copy link
Member

TL;DR

Limit the parallel ongoing deletes.

Expected behavior

To avoid too much strain on the API and possible rate-limit exhaustions we should limit the number of parallel deletes (introduced in #761). This could be made configurable with a preference too.

Not sure what a good default limit would be. We could calculate something from the default API rate limit. In practice 5 is probably high enough to give some advantage to the user, while not doing too much in parallel.

@jooola
Copy link
Member

jooola commented Jun 11, 2024

Shouldn't this be handled by some client side throttling when hitting some rate limits? For example, read the rate limits value and sleep a bit if we are about to hit the limit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants