-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invalid type for load balancer private network property #372
Conversation
d64ad05
to
310d3c7
Compare
310d3c7
to
5c39805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a "bug fix" (rather than breaking change) because only the typing was wrong, while the actual field always contained a list?
Yes, this should not be a breaking change, only the type checker might fail, but I think this is "ok". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, any code relying on this typing is "broken" in effect anyway.
🤖 I have created a release *beep* *boop* --- ## [1.33.3](v1.33.2...v1.33.3) (2024-03-27) ### Bug Fixes * invalid type for load balancer private network property ([#372](#372)) ([903e92f](903e92f)) ### Dependencies * update codecov/codecov-action action to v4 ([#359](#359)) ([a798979](a798979)) * update dependency mypy to >=1.9,<1.10 ([#368](#368)) ([4b9328c](4b9328c)) * update dependency pylint to >=3,<3.2 ([#364](#364)) ([d71d17f](d71d17f)) * update dependency pytest to >=8,<8.2 ([#366](#366)) ([8665dcf](8665dcf)) * update dependency pytest to v8 ([#357](#357)) ([f8f756f](f8f756f)) * update dependency pytest-cov to v5 ([#371](#371)) ([04a6a42](04a6a42)) * update dependency watchdog to v4 ([#360](#360)) ([cb8d383](cb8d383)) * update pre-commit hook asottile/pyupgrade to v3.15.1 ([#362](#362)) ([dd2a521](dd2a521)) * update pre-commit hook asottile/pyupgrade to v3.15.2 ([3d02ad7](3d02ad7)) * update pre-commit hook psf/black-pre-commit-mirror to v24 ([#356](#356)) ([b46397d](b46397d)) * update pre-commit hook psf/black-pre-commit-mirror to v24.1.1 ([#358](#358)) ([7e4645e](7e4645e)) * update pre-commit hook psf/black-pre-commit-mirror to v24.2.0 ([#361](#361)) ([5b56ace](5b56ace)) * update pre-commit hook psf/black-pre-commit-mirror to v24.3.0 ([3bbac5d](3bbac5d)) * update pre-commit hook pycqa/flake8 to v7 ([#354](#354)) ([66a582f](66a582f)) * update pypa/gh-action-pypi-publish action to v1.8.12 ([#365](#365)) ([55db255](55db255)) * update pypa/gh-action-pypi-publish action to v1.8.14 ([#367](#367)) ([0cb615f](0cb615f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
https://docs.hetzner.cloud/#load-balancers-get-a-load-balancer