Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSource Network id should be an integer #525

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

guineveresaenger
Copy link
Contributor

Hi there!

As per the schema definition, the id field in the documentation example should be an integer.

We've run across some doc discrepancies in our downstream Pulumi provider. Thank you so much for considering this pull request.

@guineveresaenger
Copy link
Contributor Author

Would love any insight on why this is failing CI :)

Fix pluralization of resource
@guineveresaenger
Copy link
Contributor Author

It turns out that our docs problems were caused by incomplete pluralization in the get_networks data source, rather than the quotes around the example ID string.

Thank you again!

@LKaemmerling LKaemmerling merged commit c15ae9b into hetznercloud:main Jun 22, 2022
@LKaemmerling
Copy link
Member

Hey @guineveresaenger,

good catch! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants