Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve setup instructions #49

Merged
merged 1 commit into from
Dec 29, 2020
Merged

improve setup instructions #49

merged 1 commit into from
Dec 29, 2020

Conversation

hiro5id
Copy link
Contributor

@hiro5id hiro5id commented Dec 29, 2020

This project is awesome and I got it working after spending a lot of time on it.

I am supplying this pull request to improve the instructions on the parts I got tripped up on:

  • I selected the wrong account type in the Microsoft Azure configuration, so I made that clearer with a screenshot.
  • I used the wrong redirect URI. I followed the instructions and left the index.php in the url. But when I did that I couldn't register the app, the redirect kept failing.

@codecov-io
Copy link

codecov-io commented Dec 29, 2020

Codecov Report

Merging #49 (c4c0041) into master (3652ddd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #49   +/-   ##
========================================
  Coverage      3.88%   3.88%           
  Complexity      113     113           
========================================
  Files            11      11           
  Lines           360     360           
========================================
  Hits             14      14           
  Misses          346     346           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3652ddd...c4c0041. Read the comment docs.

@hevelius hevelius merged commit e319895 into hevelius:master Dec 29, 2020
@hevelius
Copy link
Owner

Thanks @hiro5id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants