-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more log information #272
Comments
can i work on this issue |
Sure! you can proceed... You can make PRs per class with loggers added. I would prefer several small PRs rather than a big one. Please, keep in mind that the goal is not to have all classes with a lot of logging information, but to add only the bare minimum information for a programmer to know what is going on (just review the task description for all details ;) As the TODO task and the documentation task, this one won't have an assigned person as potentially many people could be working on it. |
Hi, I would like to contribute here! |
Great @pk97 !!! As there is going to be many changes for v2. It is safe to improve logging of the Hexagon Core module. However, as v1 could be in use some time after v2 release, logs can also be added to other modules. Remember to add log statements only if the provided useful information (to avoid log flood, that makes reasoning about the code harder) and follow the guidelines in the issue's description. Thanks for your interest in the project! 🙂 |
This is going to be an ongoing task.
If you find some part of the code without enough logging information, feel free to make the PR and reference this issue. However, the issue won't be closed as stated before.
Take care of the level assigned to the log statements:
error
some error stopped the correct processing of the request or the process.warn
something failed and was ignored (it wasn't a big deal to stop request or process), but it could be an issue later or with other data.info
only for really useful information that is not written very often.debug
for information with useful information to diagnose problems or failures (that could be used to diagnose client code bugs).trace
for low level details that are logged very often (information that could be used to fix this library's bugs).Rules of thumb:
This will make users be able to understand and solve problems of the toolkit much faster.
Thank you for making this library a bit better :)
The text was updated successfully, but these errors were encountered: