Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two new API's added for companies #194

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pramodshinde
Copy link

Added two new companies API's for

  • Retrieving a List of companies user currently following
  • Retrieving a List of companies suggested companies to follow

pramodshinde added 3 commits December 27, 2013 12:47
-Retrieving a List of Companies Followed
-Retrieving suggested list companies to Follow
- Retrieving a List of companies user currently following
- Retrieving a List of companies suggested companies to follow
@@ -148,6 +153,15 @@ def company_path(options)
end
end

def companies_path(options)
path = "/people/~"
if options[:suggetions]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:suggestions not :suggetions

@hexgnu
Copy link
Owner

hexgnu commented Dec 27, 2013

I think the API needs some cleanup.

#companies points to both suggested and companies that someone is following which to me violates a single responsibility. I'd rather see two methods for this like

def suggested_companies
  simple_query('/people/~/suggestions/to-follow/companies')
end

def followed_companies
  simple_query('/people/~/following/companies')
end

-Retrieving a List of companies user currently following
-Retrieving a List of companies suggested companies to follow
@pramodshinde
Copy link
Author

Nice catch for :suggestions, cleaned up for single responsibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants