Close #449 #481
Merged
Close #449 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Уже есть ПРчик #467 Предлагаю подождать @Heaven-Tonight с фиксом линтера. |
|
О как |
|
@fey, кажется это решение работает корректно и оно, на мой взгляд, по-лучше моего, можно его тогда замерджить. А я что-то прошляпила момент с воркфлоу, в следующий раз внимательнее буду) Еще и БД на Рендере пала смертью храбрых) |
|
ок, тогда поревьювим этот ПР |
dzencot
requested changes
May 20, 2024
| @@ -49,6 +49,7 @@ function SignInForm({ onSuccess = () => null }) { | |||
| email: preparedValues.email, | |||
| password: values.password, | |||
| }); | |||
| localStorage.removeItem('guestUserData'); | |||
There was a problem hiding this comment.
Предлагаю перенести это в auth.signIn()
bobronaud
force-pushed
the
add-signIn-option-for-guest
branch
from
2490845
to
6022a6f
Compare
|
внёс изменения |
move claer localstorate in signin provider
bobronaud
force-pushed
the
add-signIn-option-for-guest
branch
from
6022a6f
to
c96ca70
Compare
|
кажется, я все исправил |
Closed
|
Задеплойте демку плз |
|
у вас в ПРе какой-то левый файл. |
|
@bobronaud тыц) Тут есть лишнее в ПРе |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавил возможность войти в существующий аккаунт из гостевого аккаунта
Демо - https://bobronaud-runit2.onrender.com
Ишьюс - #449