Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Array#reduce() and Bluebird#reduce() #67

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Remove Array#reduce() and Bluebird#reduce() #67

merged 1 commit into from
Apr 27, 2020

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Apr 27, 2020

Reduce functions are difficult to optimize and are prone to penalties.
In addition, the current implementation will create and copy a nested array of arrays.

@segayuu segayuu requested review from SukkaW and curbengh April 27, 2020 13:20
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 96.233% when pulling f818364 on segayuu:Reduce-Array#reduce-and-Bluebird#reduce into 3dc8f73 on hexojs:master.

@segayuu segayuu merged commit d91788f into hexojs:master Apr 27, 2020
@segayuu segayuu deleted the Reduce-Array#reduce-and-Bluebird#reduce branch April 27, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

@curbengh curbengh Awaiting requested review from curbengh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@segayuu @coveralls @SukkaW