-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-todo-list-checkbox-issue #46
fix-todo-list-checkbox-issue #46
Conversation
…trying to fix it.
Just wonder why need to disable the check box? Even user ticked it, after refresh, it will be set back to the original. |
ok,It means that there is no need to do that? so I gonna close this PR. |
We may need it, but just feel a little bit odd if the check box is gray. We can keep this open and let others discuss this. |
ok.I think that if thecheckbox is gray, it means that this task has been done. |
@wkzcn maybe we could add a setting to support such behavior, or users modify the css class to disable it. Either way, more make sense to me. |
@NoahDragon I can't agree more. Is it more convenient for user to add a setting to support such behavior? |
I think disable checkbox is better, we can't post the form data in a static blog. |
After page rendered, visitor still can click on the checkbox. So I'm trying to fix it.