Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-todo-list-checkbox-issue #46

Conversation

leollon
Copy link

@leollon leollon commented Aug 9, 2017

After page rendered, visitor still can click on the checkbox. So I'm trying to fix it.

@coveralls
Copy link

coveralls commented Aug 9, 2017

Coverage Status

Coverage remained the same at 87.234% when pulling 5a9a478 on wkzcn:fix-todo-list-checkbox-issue into ffeca47 on hexojs:Fix-checklist-issue.

@leollon leollon changed the title After page rendered, visitor still can click on the checkbox. fix-todo-list-checkbox-issue Aug 9, 2017
@NoahDragon
Copy link
Member

Just wonder why need to disable the check box? Even user ticked it, after refresh, it will be set back to the original.

@leollon
Copy link
Author

leollon commented Aug 9, 2017

ok,It means that there is no need to do that? so I gonna close this PR.

@leollon leollon closed this Aug 10, 2017
@NoahDragon
Copy link
Member

We may need it, but just feel a little bit odd if the check box is gray. We can keep this open and let others discuss this.

@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage remained the same at 87.234% when pulling 5a9a478 on wkzcn:fix-todo-list-checkbox-issue into ffeca47 on hexojs:Fix-checklist-issue.

@leollon
Copy link
Author

leollon commented Aug 11, 2017

ok.I think that if thecheckbox is gray, it means that this task has been done.

@NoahDragon
Copy link
Member

@wkzcn maybe we could add a setting to support such behavior, or users modify the css class to disable it. Either way, more make sense to me.

@leollon
Copy link
Author

leollon commented Aug 11, 2017

@NoahDragon I can't agree more. Is it more convenient for user to add a setting to support such behavior?

@MrEleven
Copy link

I think disable checkbox is better, we can't post the form data in a static blog.
it just show the infomation todo item finished or unfinished, we can't change it by ticked the checkbox.

@yoshinorin
Copy link
Member

@leollon
We released v1.0.0.
This issue probably already been resolved. Please check it. Thanks :)

@yoshinorin yoshinorin closed this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants