Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency highlight.js #246

Merged
merged 8 commits into from
Mar 29, 2021
Merged

Update dependency highlight.js #246

merged 8 commits into from
Mar 29, 2021

Conversation

stevenjoezhang
Copy link
Member

@stevenjoezhang stevenjoezhang commented Mar 25, 2021 •
edited
Loading

@stevenjoezhang stevenjoezhang linked an issue Mar 25, 2021 that may be closed by this pull request
highlight(lang, code, ...args) has been deprecated. #245
Closed
@stevenjoezhang stevenjoezhang requested a review from a team March 25, 2021 02:35
@stevenjoezhang stevenjoezhang mentioned this pull request Mar 25, 2021
Merged
joshgoebel
joshgoebel reviewed Mar 25, 2021
View reviewed changes
Copy link

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick thoughts.

lib/highlight.js Outdated Show resolved Hide resolved
lib/highlight.js Show resolved Hide resolved
@joshgoebel
Copy link

Nice!

@stevenjoezhang stevenjoezhang mentioned this pull request Mar 25, 2021
Closed
@stevenjoezhang stevenjoezhang linked an issue Mar 25, 2021 that may be closed by this pull request
highlight() is inconsistent when code is illegal syntax #164
Closed
@stevenjoezhang stevenjoezhang mentioned this pull request Mar 25, 2021
Closed
jiangtj
jiangtj approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@jiangtj jiangtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stevenjoezhang stevenjoezhang merged commit 2bd773b into master Mar 29, 2021
@stevenjoezhang stevenjoezhang deleted the hljs branch March 29, 2021 04:12
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@stevenjoezhang @nevilm-lt
Update dependency highlight.js (hexojs#246)
d83147a
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@stevenjoezhang @nevilm-lt
Update dependency highlight.js (hexojs#246)
e457aed
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@stevenjoezhang @nevilm-lt
Update dependency highlight.js (hexojs#246)
1a87a6a
nevilm-lt pushed a commit to nevilm-lt/hexo-util that referenced this pull request Apr 22, 2022
@stevenjoezhang @nevilm-lt
Update dependency highlight.js (hexojs#246)
d7fddbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel left review comments

@jiangtj jiangtj jiangtj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@stevenjoezhang @joshgoebel @jiangtj