Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the part where the public API createSha1Hash() was not exported. #47

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Fix the part where the public API createSha1Hash() was not exported. #47

merged 1 commit into from
Nov 12, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Nov 12, 2018

No description provided.

@segayuu segayuu added the bug label Nov 12, 2018
@segayuu segayuu requested a review from a team November 12, 2018 04:16
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.687% when pulling 68b2379 on segayuu:export-createSha1Hash into 17a9b7b on hexojs:master.

yoshinorin
yoshinorin approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yoshinorin yoshinorin merged commit e847c40 into hexojs:master Nov 12, 2018
@segayuu
Copy link
Contributor Author

segayuu commented Nov 12, 2018

thank @yoshinorin !

@segayuu segayuu deleted the export-createSha1Hash branch November 12, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@segayuu @coveralls @yoshinorin