Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(package): update dependencies minor or patch version #3300

Merged
merged 2 commits into from
Oct 23, 2018
Merged

chore(package): update dependencies minor or patch version #3300

merged 2 commits into from
Oct 23, 2018

Conversation

yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Oct 22, 2018 •
edited
Loading

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Oct 22, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.27% when pulling cfa50d8 on YoshinoriN:update-dependencies into ce531c0 on hexojs:master.

segayuu
segayuu previously approved these changes Oct 23, 2018
View reviewed changes
segayuu
segayuu approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (as conflict was done after merging another PR, resolve and merge)

@segayuu segayuu merged commit 8d33f3c into hexojs:master Oct 23, 2018
@yoshinorin yoshinorin deleted the update-dependencies branch October 23, 2018 04:46
@yoshinorin
Copy link
Member Author

yoshinorin commented Oct 23, 2018 •
edited
Loading

@segayuu
Thank you for resolve conflict. From next time I will rebase and re-push by myself, if conflict occurs 😄
Sorry, basically weekday daytime I can't change OSS source code.

@snyk-bot snyk-bot mentioned this pull request Oct 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshinorin @coveralls @segayuu