Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post asset folder issue when link ends with .html #2504

Conversation

mrjohannchang
Copy link
Contributor

Fixes #2134

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Apr 10, 2017

Coverage Status

Coverage decreased (-0.05%) to 97.083% when pulling 6d6b12d on changyuheng:fix-post-asset-folder-and-html-ends-link into 657593c on hexojs:master.

@NoahDragon
Copy link
Member

Thanks for the PR. LGTM. Could you please fix the jscs error and add test cases?

@Alex1990
Copy link

Alex1990 commented May 4, 2017

@changyuheng You can just use the regular expression literal, such as /\.html$/. Note, the dot \. should not be lack of.

@stale stale bot added the wontfix This will not be worked on label Sep 27, 2017
@stale
Copy link

stale bot commented Sep 27, 2017

This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@NoahDragon NoahDragon added bug Something isn't working and removed wontfix This will not be worked on labels Sep 27, 2017
JLHwung added a commit that referenced this pull request Dec 4, 2017
JLHwung added a commit that referenced this pull request Dec 4, 2017
JLHwung added a commit that referenced this pull request Dec 4, 2017
NoahDragon pushed a commit that referenced this pull request Dec 4, 2017
@mrjohannchang mrjohannchang deleted the fix-post-asset-folder-and-html-ends-link branch May 19, 2021 00:47
@mrjohannchang mrjohannchang restored the fix-post-asset-folder-and-html-ends-link branch May 19, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants