Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parsing error about <code> tag (Issue #2563) #2568

Merged
merged 1 commit into from
May 17, 2017
Merged

Fix parsing error about <code> tag (Issue #2563) #2568

merged 1 commit into from
May 17, 2017

Conversation

seaoak
Copy link
Member

@seaoak seaoak commented May 17, 2017

  • Add test cases for the changes.
  • Passed the CI test.

This patch fixes a latent bug that causes the issue #2563.

The Pull Request #2461 (commit 5134cba) made the bug easier to be realized.

To fix the bug, change a regexp to be non-greedy.

And also add a test case and assertions.

@coveralls
Copy link

coveralls commented May 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 97.193% when pulling 8d557cc on seaoak:bugfix/issue-2563 into 4f6c384 on hexojs:master.

NoahDragon
NoahDragon approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. LGTM.

@NoahDragon NoahDragon merged commit 7f933d4 into hexojs:master May 17, 2017
This was referenced May 17, 2017
Closed
Closed
Closed
@popomore popomore mentioned this pull request May 22, 2017
Merged
NoahDragon added a commit that referenced this pull request May 23, 2017
@NoahDragon
Revert "Fix parsing error about <code> tag (Issue #2563) (#2568)"
1e57def 
This reverts commit 7f933d4.
@NoahDragon NoahDragon mentioned this pull request May 23, 2017
Merged
NoahDragon added a commit that referenced this pull request May 24, 2017
@NoahDragon
Revert "Fix parsing error about <code> tag (Issue #2563)" (#2578)
4e5ccc8 
* Revert "Update package.json"

This reverts commit a7e85aa.

* Revert "3.3.6"

This reverts commit 3c84b67.

* Revert "Fix parsing error about <code> tag (Issue #2563) (#2568)"

This reverts commit 7f933d4.

* Update tag.js

* Update tag.js

* Update post.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahDragon NoahDragon NoahDragon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seaoak @coveralls @NoahDragon