Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set the supported version of nodejs. #3007

Merged
merged 1 commit into from
Feb 3, 2018
Merged

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Feb 3, 2018

Its value is the lowest version logically tested on travis ci.

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.256% when pulling 3ee3644 on segayuu-patch-1 into 0973bca on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.256% when pulling 3ee3644 on segayuu-patch-1 into 0973bca on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.256% when pulling 3ee3644 on segayuu-patch-1 into 0973bca on master.

@segayuu
Copy link
Contributor Author

segayuu commented Feb 3, 2018

All errors that occurred in travis ci are due to too many monitored objects. It is not an error caused by changing the code itself.

Copy link
Member

@NoahDragon NoahDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Rebuild the travis-ci, the errors are gone.

@NoahDragon NoahDragon merged commit 5a9a76e into master Feb 3, 2018
@NoahDragon NoahDragon deleted the segayuu-patch-1 branch February 3, 2018 17:39
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants