Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn Workspaces #3045

Merged
merged 3 commits into from
Feb 28, 2018
Merged

Yarn Workspaces #3045

merged 3 commits into from
Feb 28, 2018

Conversation

wyattjoh
Copy link
Contributor

@wyattjoh wyattjoh commented Feb 23, 2018

Thank you for creating a pull request to contribute to Hexo code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Add test cases for the changes. Existing tests cover the functionality
  • Passed the CI test.

Pending Work

Adding full support for Yarn Workspaces requires some more work on the hexo-cli package. These are some tasks required before this PR should be merged.

@coveralls
Copy link

coveralls commented Feb 23, 2018

Coverage Status

Coverage increased (+0.003%) to 97.276% when pulling f5d2985 on wyattjoh:master into 9282712 on hexojs:master.

@wyattjoh
Copy link
Contributor Author

Issue with the older versions of node are causing the require.resolve solution to not work. It might be required to use a package like resolve to handle the resolution. Thoughts @JLHwung?

@JLHwung JLHwung merged commit 37c31b0 into hexojs:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants