Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: var to let/const in test code #3284

Merged
merged 1 commit into from
Oct 12, 2018
Merged

refactor: var to let/const in test code #3284

merged 1 commit into from
Oct 12, 2018
+1,822 −1,830

Conversation

yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Oct 11, 2018 •
edited
Loading

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.273% when pulling acb16e6 on YoshinoriN:test-code-var-to-let-or-const into 97e8f3c on hexojs:master.

segayuu
segayuu approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@segayuu segayuu merged commit d9196e3 into hexojs:master Oct 12, 2018
@yoshinorin yoshinorin deleted the test-code-var-to-let-or-const branch September 28, 2019 00:47
@snyk-bot snyk-bot mentioned this pull request Oct 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshinorin @coveralls @segayuu