Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Reflect.apply() #3289

Merged
merged 3 commits into from
Nov 3, 2018
Merged

Use Reflect.apply() #3289

merged 3 commits into from
Nov 3, 2018

Conversation

segayuu
Copy link
Contributor

@segayuu segayuu commented Oct 15, 2018

Function#call() and Function#apply() can express assertion that it converts this value more clearly by converting it to Reflect.apply().

  • Add test cases for the changes.
  • Passed the CI test.

@segayuu segayuu changed the title Use reflect apply Use Reflect.apply() Oct 15, 2018
@segayuu segayuu requested a review from a team October 15, 2018 02:18
@coveralls
Copy link

coveralls commented Oct 15, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 97.268% when pulling da84ea7 on segayuu:Use-Reflect-apply into 06745ec on hexojs:master.

@yoshinorin
Copy link
Member

It seems good. But, I can't judge clearly which is better.
I want other member's review.

@NoahDragon
Copy link
Member

LGTM, we eventually need to convert the old js code to es6, this change makes the target closer. 👍

@yoshinorin yoshinorin merged commit 0a78ca4 into hexojs:master Nov 3, 2018
@segayuu segayuu deleted the Use-Reflect-apply branch November 3, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@segayuu @coveralls @yoshinorin @NoahDragon