Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop lodash for i18n filter #3810

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@SukkaW
Copy link
Member

SukkaW commented Oct 27, 2019

What does it do?

This PR is a part of #3753.

How to test

git clone -b drop-for-lodash-for-filter-i18n https://github.com/sukkaw/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@SukkaW SukkaW requested a review from curbengh Oct 27, 2019
@SukkaW SukkaW added this to To do in Replace lodash with native API via automation Oct 27, 2019
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 27, 2019

Coverage Status

Coverage decreased (-0.0008%) to 97.263% when pulling 394ee9d on SukkaW:drop-for-lodash-for-filter-i18n into c48f6a8 on hexojs:master.

@SukkaW SukkaW requested a review from segayuu Oct 29, 2019
Replace lodash with native API automation moved this from To do to In progress Oct 31, 2019
Copy link
Member

YoshinoriN left a comment

LGTM :)

@SukkaW SukkaW merged commit 7126202 into hexojs:master Oct 31, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.0008%) to 97.263%
Details
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Replace lodash with native API automation moved this from In progress to Done Oct 31, 2019
oncletom added a commit to oncletom/hexo that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.