Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codeblock): add 'wrap' option #3848

Merged
merged 8 commits into from
Dec 1, 2019
Merged

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Nov 9, 2019

What does it do?

Continuation of #3827

How to test

git clone -b codeblock-wrap https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 97.148% when pulling e77a137 on curbengh:codeblock-wrap into 6fa7ada on hexojs:master.

@coveralls
Copy link

coveralls commented Nov 9, 2019

Coverage Status

Coverage increased (+0.005%) to 97.148% when pulling 4430f2a on curbengh:codeblock-wrap into 6fa7ada on hexojs:master.

@seaoak
Copy link
Member

seaoak commented Nov 11, 2019

@curbengh Thank you for following conversation in #3827.
The code looks good but there are two questions about the document of the parameters:

  1. Could you add the document for the wrap parameter?
  2. I can not understand the last line of the document of parameters (returns {Boolean} True if the link doesn't ...)

@curbengh curbengh added this to the v4.1.0 milestone Nov 18, 2019
@curbengh
Copy link
Contributor Author

  1. Could you add the document for the wrap parameter?

Done, meanwhile I will also update hexo.io

I can not understand the last line of the document of parameters

That was an error because I simply copy-pasted from isExternalLink().

@curbengh curbengh marked this pull request as ready for review November 18, 2019 09:33
@curbengh curbengh requested a review from a team November 18, 2019 09:34
Copy link
Member

@seaoak seaoak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@curbengh curbengh requested a review from a team November 27, 2019 08:01
@curbengh curbengh mentioned this pull request Dec 1, 2019
1 task
@curbengh curbengh merged commit a07cd68 into hexojs:master Dec 1, 2019
@curbengh curbengh deleted the codeblock-wrap branch December 1, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants