Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test-filters-save_database): async/await #3958

Merged
merged 3 commits into from
Jan 5, 2020
Merged

refactor(test-filters-save_database): async/await #3958

merged 3 commits into from
Jan 5, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 14, 2019 •
edited

What does it do?

#3328

How to test

git clone -b test-filters-save_database https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.138% when pulling 3c77a7d on curbengh:test-filters-save_database into e4a5292 on hexojs:master.

@coveralls
Copy link

coveralls commented Dec 14, 2019 •
edited

Coverage Status

Coverage remained the same at 97.086% when pulling 92731ab on curbengh:test-filters-save_database into 663f1eb on hexojs:master.

segayuu
segayuu approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@segayuu segayuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@segayuu segayuu merged commit 2ed5bbc into hexojs:master Jan 5, 2020
@curbengh curbengh deleted the test-filters-save_database branch January 10, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segayuu segayuu segayuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@curbengh @coveralls @segayuu