Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open_graph-helper): pass all pretty_urls options #3983

Merged
merged 3 commits into from Dec 20, 2019

Conversation

@curbengh
Copy link
Contributor

curbengh commented Dec 18, 2019

  • by utilizing prettyUrls() of hexo-util
  • to support pretty_urls.trailing_html

How to test

git clone -b og-pretty-urls https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 18, 2019

Coverage Status

Coverage decreased (-0.003%) to 97.108% when pulling 859bf77 on curbengh:og-pretty-urls into 3b58c63 on hexojs:master.

@SukkaW SukkaW mentioned this pull request Dec 19, 2019
0 of 2 tasks complete
@curbengh curbengh force-pushed the curbengh:og-pretty-urls branch from e45d13e to 0af7224 Dec 19, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Dec 19, 2019

rebased

@curbengh curbengh requested a review from SukkaW Dec 19, 2019
@curbengh

This comment has been minimized.

Copy link
Contributor Author

curbengh commented Dec 19, 2019

Failing test is fixed in #3993.

@SukkaW

This comment has been minimized.

Copy link
Member

SukkaW commented Dec 20, 2019

Need rebase again after #3992 is merged.

curbengh added 3 commits Dec 18, 2019
- by utilizing prettyUrls() of hexo-util
- to support pretty_urls.trailing_html
@curbengh curbengh force-pushed the curbengh:og-pretty-urls branch from 0af7224 to 859bf77 Dec 20, 2019
@SukkaW
SukkaW approved these changes Dec 20, 2019
@SukkaW SukkaW merged commit 04d34a7 into hexojs:master Dec 20, 2019
3 of 4 checks passed
3 of 4 checks passed
coverage/coveralls Coverage decreased (-0.003%) to 97.108%
Details
Travis CI - Pull Request Build Passed
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@curbengh curbengh deleted the curbengh:og-pretty-urls branch Dec 20, 2019
@SukkaW SukkaW mentioned this pull request Dec 21, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.