Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(open_graph-helper): pass all pretty_urls options #3983

Merged
merged 3 commits into from
Dec 20, 2019
Merged

fix(open_graph-helper): pass all pretty_urls options #3983

merged 3 commits into from
Dec 20, 2019

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 18, 2019 •
edited
Loading

  • by utilizing prettyUrls() of hexo-util
  • to support pretty_urls.trailing_html

How to test

git clone -b og-pretty-urls https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

coveralls commented Dec 18, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 97.108% when pulling 859bf77 on curbengh:og-pretty-urls into 3b58c63 on hexojs:master.

@curbengh curbengh mentioned this pull request Dec 18, 2019
Merged
SukkaW
SukkaW previously approved these changes Dec 18, 2019
View reviewed changes
@SukkaW SukkaW mentioned this pull request Dec 19, 2019
Merged
2 tasks
@curbengh
Copy link
Contributor Author

rebased

@curbengh curbengh requested a review from SukkaW December 19, 2019 23:15
@curbengh curbengh mentioned this pull request Dec 19, 2019
Merged
2 tasks
@curbengh
Copy link
Contributor Author

Failing test is fixed in #3993.

@SukkaW
Copy link
Member

SukkaW commented Dec 20, 2019

Need rebase again after #3992 is merged.

SukkaW
SukkaW previously approved these changes Dec 20, 2019
View reviewed changes
@SukkaW SukkaW merged commit 04d34a7 into hexojs:master Dec 20, 2019
@curbengh curbengh deleted the og-pretty-urls branch December 20, 2019 03:41
@SukkaW SukkaW mentioned this pull request Dec 21, 2019
Merged
1 task
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW