Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test-extend-tag_errors): async/await #4022

Merged
merged 2 commits into from
Jan 8, 2020
Merged

refactor(test-extend-tag_errors): async/await #4022

merged 2 commits into from
Jan 8, 2020

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Dec 31, 2019 •
edited
Loading

What does it do?

#3328

This PR also removes the unneeded console.log.

How to test

git clone -b test-extend-tag_errors https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.086% when pulling 93a9a57 on curbengh:test-extend-tag_errors into 663f1eb on hexojs:master.

@SukkaW SukkaW merged commit 3d59784 into hexojs:master Jan 8, 2020
@curbengh curbengh deleted the test-extend-tag_errors branch January 10, 2020 07:10
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@curbengh
refactor(test-extend-tag_errors): async/await (hexojs#4022)
6080bbd 
* refactor(test-extend-tag_errors): async/await + try/catch

* refactor(test-extend-tag_errors): chai.should()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curbengh @coveralls @SukkaW