Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling doesn't work beneath the TOC area #403

Closed
nkalvi opened this issue Feb 3, 2017 · 5 comments
Closed

Scrolling doesn't work beneath the TOC area #403

nkalvi opened this issue Feb 3, 2017 · 5 comments
Labels
bug Something isn't working

Comments

@nkalvi
Copy link

nkalvi commented Feb 3, 2017

Scrolling a page while the cursor is well beneath the TOC area on the right doesn't work - it feels very strange (also made me suspect that there was something wrong with my mouse).
It looks like the bottom margin of the element is causing it:

https://github.com/hexojs/site/blob/master/themes/navy/source/css/_partial/page.styl#L53

.fixed #article-toc-inner {
    position: fixed;
    top: 0;
    bottom: 0
}

Scrolling works as expected when the bottom margin is removed. If the change will not affect anything else, could you please remove the bottom margin?

@NoahDragon
Copy link
Member

Mine works well. I'm using Mac OS and Chrome.

@nkalvi
Copy link
Author

nkalvi commented Feb 4, 2017

@NoahDragon Thanks for checking. Yes, it works well under Chrome on MacOS.
But under Safari, after scrolling the page up (while the cursor is beneath the TOC), the page scrolls up a bit and scrolling stops working either up or down; it works fine when I move it in the main area or beneath the left sidebar. Also, it works fine if the bottom margin for TOC is not set to 0.
I'm not sure whether it is an issue with Safari.

@NoahDragon NoahDragon added the bug Something isn't working label Feb 4, 2017
@NoahDragon
Copy link
Member

On Win10 Chrome has the same issue.

@nkalvi
Copy link
Author

nkalvi commented Feb 4, 2017

@NoahDragon
A bit more testing - no problems under:

  • Mac - Firefox
  • Windows 10 64-bit - Edge
  • Windows 10 64-bit - Firefox

@curbengh
Copy link
Contributor

Maybe related #1042 which was fixed in #1055

#article-toc-inner now has margin-bottom derived from height of #footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants