Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toc): prevent scrolling past the footer #1055

Merged
merged 1 commit into from
Sep 6, 2019
Merged

fix(toc): prevent scrolling past the footer #1055

merged 1 commit into from
Sep 6, 2019

Conversation

curbengh
Copy link
Contributor

Check List

  • Others (Update, fix, translation, etc...)

Fixes #1042

cc @AM-77

SukkaW
SukkaW approved these changes Sep 5, 2019
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before

image

This PR

image

LGTM,

@yoshinorin yoshinorin merged commit 69de2e8 into hexojs:master Sep 6, 2019
@curbengh curbengh deleted the scrolling branch September 7, 2019 04:47
@curbengh curbengh mentioned this pull request Oct 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@SukkaW SukkaW SukkaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The footer section
3 participants
@curbengh @yoshinorin @SukkaW