Refactor test

[segayuu]

No description provided.

[tcrowe]

Haaay @segayuu 👋

I'd like to help out with this. Maybe you can do it or I can do it.

---

We can improve ./test/mocha.opts
https://gist.github.com/tcrowe/b22a63daea19eaee69fe2bc37adee854

require('chai').should(); can be removed if you --require should in ./test/mocha.opts

---

https://github.com/hexojs/warehouse/pull/47/files#diff-659252ed9705c67ef45fa76b7758f9d8R88

.should.to. can just be .should.and I don't think .to. is needed!

---

Was this helpful?

[segayuu]

Thank @tcrowe !

We can improve ./test/mocha.opts

The omission of require ('chai').should() by ./test/mocha.opts is not my preference as it destroys type inference.
On the other hand, because there are many test files, it may be correct to give preference to omitting them.

---

.should.to. can just be .should. and I don't think .to. is needed!

I personally agree, but if that is the case, it would remove the advantage that the Should-style "code composes English".
It should be uniform across all assert lines as it relates to the coding policy.
Since PR will grow to the entire test code, I think it will be a single PR even if it is done. I do not intend to do this in this PR.