format composite literals more nicely #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hack (but a quite functional one) to split composite literals across multiple lines to avoid extra long struct values - which are a major problem with Valast today and e.g. block me from releasing the [autogold](https://github.com/hexops/autogold) package. We will defer this to gofumpt [once it can perform this functionality.](mvdan/gofumpt#70) Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Codecov Report
@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 71.96% 73.15% +1.18%
==========================================
Files 1 2 +1
Lines 610 663 +53
==========================================
+ Hits 439 485 +46
- Misses 126 132 +6
- Partials 45 46 +1
Continue to review full report at Codecov.
|
slimsag
added a commit
that referenced
this pull request
Feb 18, 2021
With complex data types, this can provide a 66% performance improvement.
Before:
```
$ go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/hexops/valast
BenchmarkComplexType-16 2 564812395 ns/op
PASS
ok github.com/hexops/valast 9.372s
```
After:
```
$ go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/hexops/valast
BenchmarkComplexType-16 6 189646854 ns/op
PASS
ok github.com/hexops/valast 6.379s
```
In practice this can result in tests running much faster, before:
```
--- PASS: TestUnionMerge (6.38s)
--- PASS: TestUnionMerge/#00 (1.42s)
--- PASS: TestUnionMerge/#1 (1.17s)
--- PASS: TestUnionMerge/#2 (2.32s)
--- PASS: TestUnionMerge/#3 (0.00s)
--- PASS: TestUnionMerge/#4 (0.00s)
--- PASS: TestUnionMerge/#5 (1.46s)
```
After:
```
--- PASS: TestUnionMerge (2.96s)
--- PASS: TestUnionMerge/#00 (1.05s)
--- PASS: TestUnionMerge/#1 (0.77s)
--- PASS: TestUnionMerge/#2 (0.77s)
--- PASS: TestUnionMerge/#3 (0.00s)
--- PASS: TestUnionMerge/#4 (0.00s)
--- PASS: TestUnionMerge/#5 (0.37s)
```
Also appears to fix hexops/autogold#16
Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
slimsag
added a commit
that referenced
this pull request
Feb 18, 2021
With complex data types, this can provide a 66% performance improvement.
Before:
```
$ go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/hexops/valast
BenchmarkComplexType-16 2 564812395 ns/op
PASS
ok github.com/hexops/valast 9.372s
```
After:
```
$ go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/hexops/valast
BenchmarkComplexType-16 6 189646854 ns/op
PASS
ok github.com/hexops/valast 6.379s
```
In practice this can result in tests running much faster, before:
```
--- PASS: TestUnionMerge (6.38s)
--- PASS: TestUnionMerge/#00 (1.42s)
--- PASS: TestUnionMerge/#1 (1.17s)
--- PASS: TestUnionMerge/#2 (2.32s)
--- PASS: TestUnionMerge/#3 (0.00s)
--- PASS: TestUnionMerge/#4 (0.00s)
--- PASS: TestUnionMerge/#5 (1.46s)
```
After:
```
--- PASS: TestUnionMerge (2.96s)
--- PASS: TestUnionMerge/#00 (1.05s)
--- PASS: TestUnionMerge/#1 (0.77s)
--- PASS: TestUnionMerge/#2 (0.77s)
--- PASS: TestUnionMerge/#3 (0.00s)
--- PASS: TestUnionMerge/#4 (0.00s)
--- PASS: TestUnionMerge/#5 (0.37s)
```
Also appears to fix hexops/autogold#16
Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack (but a quite functional one) to split composite literals
across multiple lines to avoid extra long struct values - which are a
major problem with Valast today and e.g. block me from releasing the
autogold package.
We will defer this to gofumpt once it can perform this functionality.
Signed-off-by: Stephen Gutekanst stephen@hexops.com