Add type expression cache (66% performance improvement) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With complex data types, this can provide a 66% performance improvement.
Before:
```
$ go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/hexops/valast
BenchmarkComplexType-16 2 564812395 ns/op
PASS
ok github.com/hexops/valast 9.372s
```
After:
```
$ go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/hexops/valast
BenchmarkComplexType-16 6 189646854 ns/op
PASS
ok github.com/hexops/valast 6.379s
```
In practice this can result in tests running much faster, before:
```
--- PASS: TestUnionMerge (6.38s)
--- PASS: TestUnionMerge/#00 (1.42s)
--- PASS: TestUnionMerge/#1 (1.17s)
--- PASS: TestUnionMerge/#2 (2.32s)
--- PASS: TestUnionMerge/#3 (0.00s)
--- PASS: TestUnionMerge/#4 (0.00s)
--- PASS: TestUnionMerge/#5 (1.46s)
```
After:
```
--- PASS: TestUnionMerge (2.96s)
--- PASS: TestUnionMerge/#00 (1.05s)
--- PASS: TestUnionMerge/#1 (0.77s)
--- PASS: TestUnionMerge/#2 (0.77s)
--- PASS: TestUnionMerge/#3 (0.00s)
--- PASS: TestUnionMerge/#4 (0.00s)
--- PASS: TestUnionMerge/#5 (0.37s)
```
Also appears to fix hexops/autogold#16
Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
slimsag
added a commit
to hexops/autogold
that referenced
this pull request
Feb 18, 2021
…ne formatting) * 66% performance improvement: hexops/valast#10 * Fixes performance issues on very large structures: #16 * Improves formatting of very long lines: mvdan/gofumpt#70 (comment) Signed-off-by: Stephen Gutekanst <stephen@hexops.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With complex data types, this can provide a 66% performance improvement.
Before:
After:
In practice this can result in tests running much faster, before:
After:
Also appears to fix hexops/autogold#16
Signed-off-by: Stephen Gutekanst stephen@hexops.com