Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Distortion widgets in Instrument Calibration #90

Closed
psavery opened this issue Aug 2, 2019 · 2 comments
Closed

Changes to Distortion widgets in Instrument Calibration #90

psavery opened this issue Aug 2, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@psavery
Copy link
Collaborator

psavery commented Aug 2, 2019

We should add a "None" option to the "Function" combo box list, as sometimes there will be no distortion functions for the detector.

Also, different functions use different numbers of parameters. The GE_41RT uses 6 parameters, and a new one that will be added next week uses 8 parameters.

Perhaps we should remove the parameter widgets and put a "Configure" button, which pops up a dialog, and then the dialog will provide the edit-able widgets (and the correct number of them).

We could also just change the number of widgets in the instrument calibration panel depending on the currently selected distortion function.

Changes requested by @joelvbernier

@joelvbernier
Copy link
Member

distortion can be a pop-out. we will move the distortion module to a package utilizing abstract base classes and a registry so we can add functions. The API for a distortion class will have a property yielding the number of parameters and their names...

@psavery
Copy link
Collaborator Author

psavery commented Jul 8, 2020

I think this one can be closed in favor of #379. We will continue exploring new options for the distortion, though.

@psavery psavery closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants