-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise #7
Comments
Seems like updating leaf fields is incorrect: some may not exist due to template field processing. So we need to do one of the following:
|
Attempts to prevent fields from being updated more than once. WIP.
That'll do for now. Full updates only occur if the Updates are now fully reliant on Back to being snappy. ✌️ |
Actually still an issue, initial update is still revisiting way too many fields. |
Fixed this by restoring a missing visited field pass-through in updatePath().
Fixed lol. 🎉 |
Value caching is quite wrong on initial update, so this needs reworking. |
Complete updates are expensive because they update every field regardless of what's changed. This can be optimised by diffing the given data with the current form data, and only updating the leaf paths that changed.
In some situations it may be faster to only update the common ancestors that changed, but typically the form structure is fairly static.
The text was updated successfully, but these errors were encountered: