Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape keys in schemas starting with digit but and containing non-digit characters #502

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Apr 27, 2024

Closes #496

Copy link

stackblitz bot commented Apr 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Apr 27, 2024

🦋 Changeset detected

Latest commit: 8112507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review April 27, 2024 16:44
Copy link

vercel bot commented Apr 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 4:45pm

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 29.62963% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 79.11%. Comparing base (ffd237d) to head (8112507).

Files Patch % Lines
packages/openapi-ts/src/utils/write/schemas.ts 26.31% 14 Missing ⚠️
packages/openapi-ts/src/compiler/types.ts 37.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   79.00%   79.11%   +0.11%     
==========================================
  Files          74       74              
  Lines        6100     6109       +9     
  Branches      608      617       +9     
==========================================
+ Hits         4819     4833      +14     
+ Misses       1280     1273       -7     
- Partials        1        3       +2     
Flag Coverage Δ
unittests 79.11% <29.62%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 13ebddc into main Apr 27, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the fix/schemas-key-escape branch April 27, 2024 17:55
@github-actions github-actions bot mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid identifier created (starting with digits)
1 participant