Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue causing code to not generate (t.filter is not a function) #507

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

jordanshatford
Copy link
Collaborator

closes: #481

Copy link

stackblitz bot commented Apr 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Apr 28, 2024

🦋 Changeset detected

Latest commit: a3220ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 10:30pm

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 79.00%. Comparing base (e3b9876) to head (a3220ef).

Files Patch % Lines
packages/openapi-ts/src/compiler/types.ts 50.00% 11 Missing ⚠️
packages/openapi-ts/src/compiler/typedef.ts 33.33% 2 Missing ⚠️
packages/openapi-ts/src/compiler/classes.ts 0.00% 1 Missing ⚠️
packages/openapi-ts/src/utils/write/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   78.99%   79.00%           
=======================================
  Files          74       74           
  Lines        6118     6125    +7     
  Branches      617      619    +2     
=======================================
+ Hits         4833     4839    +6     
- Misses       1282     1283    +1     
  Partials        3        3           
Flag Coverage Δ
unittests 79.00% <44.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/openapi-ts/src/compiler/types.ts Outdated Show resolved Hide resolved
packages/openapi-ts/src/compiler/types.ts Outdated Show resolved Hide resolved
packages/openapi-ts/src/compiler/types.ts Outdated Show resolved Hide resolved
packages/openapi-ts/src/compiler/types.ts Outdated Show resolved Hide resolved
packages/openapi-ts/src/compiler/typedef.ts Outdated Show resolved Hide resolved
@jordanshatford jordanshatford merged commit aade9b0 into main Apr 29, 2024
15 of 16 checks passed
@jordanshatford jordanshatford deleted the fix/t-filter-not-function branch April 29, 2024 22:43
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t.filter is not a function
2 participants