Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): handle type array #533

Merged
merged 1 commit into from
May 5, 2024
Merged

fix(parser): handle type array #533

merged 1 commit into from
May 5, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented May 5, 2024

Closes #525

Copy link

stackblitz bot commented May 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented May 5, 2024

🦋 Changeset detected

Latest commit: ead22bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 8:22am

@mrlubos mrlubos marked this pull request as ready for review May 5, 2024 08:22
Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 63.52941% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 76.54%. Comparing base (f57123b) to head (ead22bf).

Files Patch % Lines
packages/openapi-ts/src/utils/write/type.ts 5.88% 16 Missing ⚠️
packages/openapi-ts/src/compiler/typedef.ts 16.66% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   76.66%   76.54%   -0.13%     
==========================================
  Files          75       75              
  Lines        6441     6497      +56     
  Branches      624      632       +8     
==========================================
+ Hits         4938     4973      +35     
- Misses       1500     1521      +21     
  Partials        3        3              
Flag Coverage Δ
unittests 76.54% <63.52%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -3159,7 +3158,7 @@
"maxItems": 3
},
"ModelWithAnyOfConstantSizeArrayNullable": {
"type": "array",
"type": ["array"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

@mrlubos mrlubos merged commit 7d3a897 into main May 5, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/type-array-3-1 branch May 5, 2024 08:30
@github-actions github-actions bot mentioned this pull request May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missed type for type: ['array'], produces unknown[]
2 participants