all: use ptr instead of value

heyxkhoa · Sep 13, 2022 · cfc3cfb · cfc3cfb
1 parent ec526c2
commit cfc3cfb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/internal/dhcpd/dhcpd.go b/internal/dhcpd/dhcpd.go
@@ -182,7 +182,7 @@ type Interface interface {
 }
 
 // Create - create object
-func Create(conf ServerConfig) (s *server, err error) {
+func Create(conf *ServerConfig) (s *server, err error) {
 	s = &server{
 		conf: &ServerConfig{
 			ConfigModified: conf.ConfigModified,

diff --git a/internal/home/clients_test.go b/internal/home/clients_test.go
@@ -282,7 +282,7 @@ func TestClientsAddExisting(t *testing.T) {
 		ip := net.IP{1, 2, 3, 4}
 
 		// First, init a DHCP server with a single static lease.
-		config := dhcpd.ServerConfig{
+		config := &dhcpd.ServerConfig{
 			Enabled:    true,
 			DBFilePath: "leases.db",
 			Conf4: dhcpd.V4ServerConf{

diff --git a/internal/home/config.go b/internal/home/config.go
@@ -112,7 +112,7 @@ type configuration struct {
 	WhitelistFilters []filter `yaml:"whitelist_filters"`
 	UserRules        []string `yaml:"user_rules"`
 
-	DHCP dhcpd.ServerConfig `yaml:"dhcp"`
+	DHCP *dhcpd.ServerConfig `yaml:"dhcp"`
 
 	// Clients contains the YAML representations of the persistent clients.
 	// This field is only used for reading and writing persistent client data.
@@ -232,7 +232,7 @@ var config = &configuration{
 		PortDNSOverTLS:  defaultPortTLS, // needs to be passed through to dnsproxy
 		PortDNSOverQUIC: defaultPortQUIC,
 	},
-	DHCP: dhcpd.ServerConfig{
+	DHCP: &dhcpd.ServerConfig{
 		LocalDomainName: "lan",
 	},
 	Clients: &clientsConfig{
@@ -433,7 +433,7 @@ func (c *configuration) write() (err error) {
 	}
 
 	if Context.dhcpServer != nil {
-		Context.dhcpServer.WriteDiskConfig(&config.DHCP)
+		Context.dhcpServer.WriteDiskConfig(config.DHCP)
 	}
 
 	config.Clients.Persistent = Context.clients.forConfig()