-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-65] Add skeleton loader for loading images #59
Comments
@bigint What images (in what page or location) does this refer to? For images in posts, there is a grey background before the images has loaded, which looks OK in my opinion. On the NFT page for a user, there's already a skeleton loader. Is there some other place that needs skeleton loader? |
Hi @bigint please assign me to this task :) |
@richardgreg assigned 🚀 |
@bigint please assign me this task for submission. i was the one that did it on dework and you said i should have a PR repo for re submission. |
@Creed1732 Sure, go ahead and work on it. Though it seems lenster already has the skeleton loader feature. Or am I missing something? |
yea, they have that already...but not for the images...btw are you a moderator?.... |
No, a contributor |
I already did the task, just waiting to get assigned so i'll make submissions @richardgreg |
@Creed1732 assigned |
@bigint check submission |
@Creed1732 where is the PR? |
Hi @bigint, had a quick look at this. Which images would we be trying to add a loading shimmer to? As far as I can see, in publications, the |
I could not find #59 where i was to compare branches |
is the issue open rn? |
This issue has been locked since it has been closed for more than 10 days. If you found a concrete bug or regression related to it, please open a new bug report. |
null
ENG-65
The text was updated successfully, but these errors were encountered: