Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-65] Add skeleton loader for loading images #59

Closed
bigint opened this issue Jul 20, 2022 · 15 comments
Closed

[ENG-65] Add skeleton loader for loading images #59

bigint opened this issue Jul 20, 2022 · 15 comments
Assignees

Comments

@bigint
Copy link
Member

bigint commented Jul 20, 2022

null

ENG-65

@bigint bigint added this to the v1.0.3-beta milestone Aug 9, 2022
@bigint bigint modified the milestones: v1.0.3-beta, v1.0.4-beta Oct 28, 2022
@bigint bigint modified the milestones: v1.0.4-beta, v1.0.5-beta Nov 28, 2022
@foolo
Copy link
Contributor

foolo commented Dec 12, 2022

@bigint What images (in what page or location) does this refer to? For images in posts, there is a grey background before the images has loaded, which looks OK in my opinion. On the NFT page for a user, there's already a skeleton loader. Is there some other place that needs skeleton loader?

@bigint bigint modified the milestones: v1.0.5-beta, v1.0.6-beta Dec 26, 2022
@richardgreg
Copy link
Contributor

Hi @bigint please assign me to this task :)

@bigint bigint modified the milestones: v1.0.6-beta, v1.0.8-beta Mar 2, 2023
@bigint bigint added this to the Sprint Interactive milestone Mar 18, 2023
@bigint
Copy link
Member Author

bigint commented Mar 18, 2023

@richardgreg assigned 🚀

@bigint bigint removed this from the Sprint Interactive milestone Mar 19, 2023
@bigint bigint added the Bounty label Mar 31, 2023
@Creed1732
Copy link

@bigint please assign me this task for submission. i was the one that did it on dework and you said i should have a PR repo for re submission.

@richardgreg
Copy link
Contributor

@Creed1732 Sure, go ahead and work on it. Though it seems lenster already has the skeleton loader feature. Or am I missing something?

@Creed1732
Copy link

yea, they have that already...but not for the images...btw are you a moderator?....
just asking...

@richardgreg
Copy link
Contributor

No, a contributor

@Creed1732
Copy link

I already did the task, just waiting to get assigned so i'll make submissions @richardgreg

@richardgreg richardgreg removed their assignment Apr 7, 2023
@bigint
Copy link
Member Author

bigint commented Apr 7, 2023

@Creed1732 assigned

@Creed1732
Copy link

@bigint check submission

@bigint
Copy link
Member Author

bigint commented Apr 13, 2023

@Creed1732 where is the PR?

@brymut
Copy link

brymut commented Apr 13, 2023

Hi @bigint, had a quick look at this. Which images would we be trying to add a loading shimmer to? As far as I can see, in publications, the PublicationPageShimmer would cover the whole post including the image in the post and the rest seem to be covered as mentioned here, #59 (comment). Could you please clarify on how this would be handled?

@Creed1732
Copy link

I could not find #59 where i was to compare branches

@bigint bigint added linear and removed linear labels Sep 13, 2023
@bigint bigint changed the title Add skeleton loader for loading images [ENG-65] Add skeleton loader for loading images Sep 13, 2023
@bigint bigint assigned bigint and unassigned bhavya2611 Sep 13, 2023
@Sahil-B07
Copy link

Sahil-B07 commented Oct 30, 2023

is the issue open rn?
would like to work on it

@bigint bigint closed this as completed Dec 11, 2023
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants