feat: show time ago timestamp under message tile (#947) #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@foolo is attempting to deploy a commit to the Lenster Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bigint
approved these changes
Nov 9, 2022
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2022 Lenster Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
|
@bigint If you think that the hovering feature was a good addition, I can add it to other places as well. Personally I find such a feature helpful whenever a website shows me a relative date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On /messages page, change from showing absolute datetime for a message, to showing "x days/hours/minutes ago".
Also added a title attribute so that the absolute datetime is shown when hovering mouse over the "x ago" label.
Fixes #947
Type of change
How should this be tested?
Open a message conversation and check that timestamps are shown as e.g. "5 minutes ago"