Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spellcheck #1216

Merged
merged 3 commits into from
Nov 16, 2022
Merged

fix: spellcheck #1216

merged 3 commits into from
Nov 16, 2022

Conversation

foolo
Copy link
Contributor

@foolo foolo commented Nov 15, 2022

What does this PR do?

Fixes #278
I ran CSpell in the whole repo, and fixed errors that were found.

I divided the fixes into two commits: One for UI strings, and one for code.
@bigint If you think that only the UI strings should be changed, and not the code, just tell and I can just remove the second commit from the PR.

Note: I have not proofread all the files manually :) I think that a manual proofread can be done more easily after all UI strings have been moved to i18next translation files (i.e. after issue #341 has been implemented)

Finally, there is one typo, "Pubication", in a GraphQL call in src/components/Shared/Pending.tsx:

const HAS_PUBLICATION_INDEXED_QUERY = gql`
  query HasPubicationIndexed($request: PublicationQueryRequest!) {

But it seems like fixing this typo might break the query, so I left it unchanged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@foolo foolo requested a review from bigint as a code owner November 15, 2022 19:17
@vercel
Copy link

vercel bot commented Nov 15, 2022

@foolo is attempting to deploy a commit to the Lenster Team on Vercel.

A member of the Team first needs to authorize it.

@foolo foolo changed the title Spellcheck fix: spellcheck Nov 15, 2022
@@ -186,8 +186,8 @@
className="w-6 h-6"
height={24}
width={24}
src={getTokenImage(selectedCurrencySymobol)}
alt={selectedCurrencySymobol}
src={getTokenImage(selectedCurrencySymbol)}

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML

[DOM text](1) is reinterpreted as HTML without escaping meta-characters.
Copy link
Member

@bigint bigint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Rad LGTM

@vercel
Copy link

vercel bot commented Nov 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 16, 2022 at 7:45AM (UTC)

@bigint bigint merged commit 3f66382 into heyxyz:main Nov 16, 2022
@vercel vercel bot temporarily deployed to Preview November 16, 2022 07:45 Inactive
@foolo foolo deleted the spellcheck branch November 16, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do typo check across the repo
2 participants