Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: see through lens #1280

Merged
merged 16 commits into from
Nov 23, 2022
Merged

feat: see through lens #1280

merged 16 commits into from
Nov 23, 2022

Conversation

sasicodes
Copy link
Contributor

@sasicodes sasicodes commented Nov 22, 2022

What does this PR do?

Fixes #1053

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Nov 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 7:44AM (UTC)
web ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 7:44AM (UTC)

@sasicodes sasicodes self-assigned this Nov 22, 2022
@sasicodes sasicodes changed the title C through lens See through lens Nov 22, 2022
@bigint bigint changed the title See through lens feat: see through lens Nov 23, 2022
@bigint
Copy link
Member

bigint commented Nov 23, 2022

Still I don't see a spinner 😕

Can we make a different query to fetch only users from the timeline after clicking on the select component?

@bigint
Copy link
Member

bigint commented Nov 23, 2022

Always make sure to have conventional PR names 🙏🏼 😊

@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 03:58 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 06:28 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 23, 2022 06:29 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 06:31 Inactive
@vercel vercel bot temporarily deployed to Preview – web November 23, 2022 07:44 Inactive
@vercel vercel bot temporarily deployed to Preview – api November 23, 2022 07:44 Inactive
@bigint bigint merged commit 682aca3 into main Nov 23, 2022
@bigint bigint deleted the c-through-lens branch November 23, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

See the feed through the lens of someone else
2 participants