Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add follow modal in user profile #1667

Merged
merged 10 commits into from
Feb 7, 2023
Merged

fix: add follow modal in user profile #1667

merged 10 commits into from
Feb 7, 2023

Conversation

foolo
Copy link
Contributor

@foolo foolo commented Jan 23, 2023

What does this PR do?

Add a follow user modal when visiting profile with ?showFollowDialog=true in url
Screenshot_2023-01-23_09-37-38

Fixes #1417
Screen recording

Behavior:

  • If already following: don't show the modal (an alternative would be to show "you already follow this user")
  • If not logged in, show the modal. If user clicks Follow, the login flow will start

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

Open a profile, with query ?showFollowDialog=true added to the url, for example:
https://lenster-b3i5tangl-foolo.vercel.app/u/olof3?showFollowDialog=true

@foolo foolo requested a review from bigint as a code owner January 23, 2023 08:38
@height
Copy link

height bot commented Jan 23, 2023

This pull request has been linked to and will mark 2 tasks as "Done" when merged:

@vercel
Copy link

vercel bot commented Jan 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
api ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 7:56AM (UTC)
embed 🔄 Building (Inspect) Feb 7, 2023 at 7:56AM (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 7:56AM (UTC)

@vercel vercel bot temporarily deployed to Preview – api January 23, 2023 08:41 Inactive
@vercel vercel bot temporarily deployed to Preview – embed January 23, 2023 08:41 Inactive
@vercel vercel bot temporarily deployed to Preview – web January 23, 2023 08:49 Inactive
@vercel vercel bot temporarily deployed to Preview – api January 27, 2023 11:51 Inactive
@vercel vercel bot temporarily deployed to Preview – embed January 27, 2023 11:57 Inactive
@vercel vercel bot temporarily deployed to Preview – web January 27, 2023 12:00 Inactive
@vercel vercel bot temporarily deployed to Preview – embed January 28, 2023 07:02 Inactive
@vercel vercel bot temporarily deployed to Preview – api January 28, 2023 07:03 Inactive
@vercel vercel bot temporarily deployed to Preview – web January 28, 2023 07:05 Inactive
# Conflicts:
#	apps/web/src/components/Profile/index.tsx
#	apps/web/src/components/Shared/Follow.tsx
#	apps/web/src/components/UI/Modal.tsx
@vercel vercel bot temporarily deployed to Preview – api February 2, 2023 09:39 Inactive
@vercel vercel bot temporarily deployed to Preview – web February 2, 2023 09:41 Inactive
@vercel vercel bot temporarily deployed to Preview – api February 2, 2023 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview – web February 2, 2023 15:29 Inactive
apps/web/src/components/Profile/index.tsx Outdated Show resolved Hide resolved
apps/web/src/components/Profile/index.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – api February 6, 2023 16:46 Inactive
@vercel vercel bot temporarily deployed to Preview – web February 6, 2023 16:48 Inactive
@vercel vercel bot temporarily deployed to Preview – api February 6, 2023 18:21 Inactive
@vercel vercel bot temporarily deployed to Preview – web February 6, 2023 18:22 Inactive
@bigint bigint enabled auto-merge (squash) February 7, 2023 07:55
@vercel vercel bot temporarily deployed to Preview – api February 7, 2023 07:55 Inactive
@bigint
Copy link
Member

bigint commented Feb 7, 2023

Close T-2607

@bigint
Copy link
Member

bigint commented Feb 7, 2023

Close T-2608

@bigint bigint merged commit b940cbe into heyxyz:main Feb 7, 2023
@vercel vercel bot temporarily deployed to Preview – web February 7, 2023 07:56 Inactive
@foolo foolo deleted the follow-modal-1417 branch February 7, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add follow modal in user profile
2 participants