Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile name overflow #1885

Merged
merged 3 commits into from
Mar 1, 2023
Merged

fix: profile name overflow #1885

merged 3 commits into from
Mar 1, 2023

Conversation

sasicodes
Copy link
Contributor

@sasicodes sasicodes commented Mar 1, 2023

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@sasicodes sasicodes requested a review from bigint as a code owner March 1, 2023 12:26
@height
Copy link

height bot commented Mar 1, 2023

This pull request has been linked to 1 task:

💡Tip: Add "Close T-6265" to the pull request title or description, to a commit message, or in a comment to mark this task as "Done" when the pull request is merged.

@sasicodes sasicodes self-assigned this Mar 1, 2023
@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
prerender ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 1, 2023 at 3:38PM (UTC)
web 🛑 Canceled (Inspect) 💬 Add your feedback Mar 1, 2023 at 3:38PM (UTC)

@vercel vercel bot temporarily deployed to Preview – web March 1, 2023 12:27 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender March 1, 2023 12:27 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender March 1, 2023 14:24 Inactive
@vercel vercel bot temporarily deployed to Preview – web March 1, 2023 14:25 Inactive
@bigint
Copy link
Member

bigint commented Mar 1, 2023

Thanks bruv! but gonna merge this #1886

@bigint bigint closed this Mar 1, 2023
@bigint bigint reopened this Mar 1, 2023
@bigint bigint merged commit d6305e5 into main Mar 1, 2023
@bigint bigint deleted the T-6265/profile-text-overflows branch March 1, 2023 15:35
@vercel vercel bot temporarily deployed to Preview – web March 1, 2023 15:36 Inactive
@vercel vercel bot temporarily deployed to Preview – prerender March 1, 2023 15:38 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants